Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #114

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Update README.md #114

merged 1 commit into from
Oct 29, 2018

Conversation

dglazer
Copy link
Member

@dglazer dglazer commented Oct 29, 2018

HI @jaeddy -- I made a couple more small README cleanups:
a) fixed the same typo in the link to the Swagger Editor as in the earlier PR
b) deleted one of the two redundant sections with links to viewing the API (to avoid future drift)

Let me know if you disagree with (b) -- I'm about 80% sure it makes sense, but am open to discussion.

@dglazer dglazer requested a review from jaeddy October 29, 2018 12:46
jaeddy
jaeddy approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@jaeddy jaeddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The 'How to View' section was from when I was previously trying to explain all the branch-specific 'preview' links. I moved some of that stuff to the contributing docs, so I agree it's redundant here.

@jaeddy jaeddy merged commit 41c2607 into develop Oct 29, 2018
@dglazer dglazer deleted the dglazer-readme-howtoview-cleanup branch October 29, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeddy jaeddy jaeddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dglazer @jaeddy